Issue #5: add c++ to test suite #6

Open
marmaduke wants to merge 3 commits from issue/5-add-c-to-test-suite into ins-local
Owner

Summary

Adds the C++ test suite to the CI workflow so that cpp-base tests run on every push/PR alongside the existing pytest-base job.

What changed

  • Added a cpp-base job to .github/workflows/ci.yml that uses the nvidia/cuda:13.1.2-devel-ubuntu24.04 container, installs build dependencies, configures with BUILD_TESTING=ON, and runs ctest.

Key decisions

  • Separate job (not merged into pytest-base): the base images are incompatible, so a dedicated job is cleaner.
  • GPU tests skip gracefully: all GPU-dependent tests return exit code 77 when no GPU is present; CTest marks these as Not Run.
  • Host-side tests execute normally: about 90 tests that do not require a GPU run and provide real signal on every CI run.
  • Same CUDA base image as production Dockerfile: keeps the toolchain consistent.

How to verify

  • Push to a branch and watch the cpp-base job in CI.
  • Locally: cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=ON and cmake --build build -j and ctest --test-dir build --output-on-failure
## Summary Adds the C++ test suite to the CI workflow so that `cpp-base` tests run on every push/PR alongside the existing `pytest-base` job. ## What changed - Added a `cpp-base` job to `.github/workflows/ci.yml` that uses the `nvidia/cuda:13.1.2-devel-ubuntu24.04` container, installs build dependencies, configures with BUILD_TESTING=ON, and runs ctest. ## Key decisions - Separate job (not merged into pytest-base): the base images are incompatible, so a dedicated job is cleaner. - GPU tests skip gracefully: all GPU-dependent tests return exit code 77 when no GPU is present; CTest marks these as Not Run. - Host-side tests execute normally: about 90 tests that do not require a GPU run and provide real signal on every CI run. - Same CUDA base image as production Dockerfile: keeps the toolchain consistent. ## How to verify - Push to a branch and watch the cpp-base job in CI. - Locally: cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=ON and cmake --build build -j and ctest --test-dir build --output-on-failure
issue/5: add C++ test suite to CI
Some checks failed
ci / cpp-base (pull_request) Failing after 1m17s
ci / pytest-base (pull_request) Successful in 3m1s
bb1dad39c6
Add a cpp-base CI job that builds the full C++ test suite using the
nvidia/cuda:13.1.2-devel-ubuntu24.04 container and runs ctest.

GPU-dependent tests (ops, device, arena, kv-cache, state-store, and
target integration tests) skip gracefully with return code 77 on the
headless runner. Host-side tests (public API, artifact reader, media
decode, prompt input, protocol/serve, sampling, CLI options, context
cost, admission policy, resource manager, and other pure-host tests)
execute normally.

The job mirrors the main Dockerfile's build dependencies (cmake,
ninja, pkg-config, ffmpeg dev libs, libcurl dev) and uses the same
CUDA base image for consistency.
issue/5: fix CI failure
Some checks failed
ci / cpp-base (pull_request) Failing after 31s
ci / pytest-base (pull_request) Has been cancelled
988df90919
issue/5: fix CI failure
Some checks failed
ci / pytest-base (pull_request) Successful in 2m31s
ci / cpp-base (pull_request) Has been cancelled
3cf9cba6c7
Some checks failed
ci / pytest-base (pull_request) Successful in 2m31s
ci / cpp-base (pull_request) Has been cancelled
This pull request has changes conflicting with the target branch.
  • .github/workflows/ci.yml
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin issue/5-add-c-to-test-suite:issue/5-add-c-to-test-suite
git switch issue/5-add-c-to-test-suite

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch ins-local
git merge --no-ff issue/5-add-c-to-test-suite
git switch issue/5-add-c-to-test-suite
git rebase ins-local
git switch ins-local
git merge --ff-only issue/5-add-c-to-test-suite
git switch issue/5-add-c-to-test-suite
git rebase ins-local
git switch ins-local
git merge --no-ff issue/5-add-c-to-test-suite
git switch ins-local
git merge --squash issue/5-add-c-to-test-suite
git switch ins-local
git merge --ff-only issue/5-add-c-to-test-suite
git switch ins-local
git merge issue/5-add-c-to-test-suite
git push origin ins-local
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
marmaduke/ninfer-4090!6
No description provided.